Add --with-plugins to run task #125468
Merged
Add --with-plugins to run task #125468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ```
rjernst
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
reviewed
Mar 24, 2025
| for (String plugin : this.plugins) { | ||
| cluster.plugin(":plugins:" + plugin); | ||
| } | ||
| ; |
breskeby
approved these changes
Mar 24, 2025
| this.plugins = Arrays.asList(plugins.split(",")); | ||
| for (var cluster : getClusters()) { | ||
| for (String plugin : this.plugins) { | ||
| cluster.plugin(":plugins:" + plugin); |
There was a problem hiding this comment.
plain FYI. I noticed this is incompatible with Gradle Configuration cache. that's likely not a big deal for using ./gradlew run at the moment, but we will rework or remove cluster.plugin(String) and cluster.module(String) at one point as it breaks configuration compatibility.
This was referenced Mar 24, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 24, 2025
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ```
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 24, 2025
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ```
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 24, 2025
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ```
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ```
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 8, 2025
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: ``` ./gradlew run --with-plugins=analysis-icu,analysis-nori ``` Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new command line option to the run task to include plugins. The option takes in a comma separated list of plugins from the plugins directory. For example: